Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run only integration tests in nightlies #1367

Closed
wants to merge 1 commit into from

Conversation

vzaidman
Copy link
Contributor

@vzaidman vzaidman commented Oct 7, 2024

Differential Revision: D63977061

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

vzaidman added a commit to vzaidman/metro that referenced this pull request Oct 7, 2024
Summary: Pull Request resolved: facebook#1367

Differential Revision: D63977061
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

vzaidman added a commit to vzaidman/metro that referenced this pull request Oct 7, 2024
Summary: Pull Request resolved: facebook#1367

Differential Revision: D63977061
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

vzaidman added a commit to vzaidman/metro that referenced this pull request Oct 7, 2024
Summary: Pull Request resolved: facebook#1367

Differential Revision: D63977061
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

vzaidman added a commit to vzaidman/metro that referenced this pull request Oct 7, 2024
Summary:

Limit the tests we run when installing packages with no `yarn.lock` to integration tests only to not be bothered by minor API changes such as babel typing update 
 that [broke nightlies](https://github.com/facebook/metro/actions/runs/11209024584/job/31153626188) this week. 

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D63977061
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

vzaidman added a commit to vzaidman/metro that referenced this pull request Oct 7, 2024
Summary:

Limit the tests we run when installing packages with no `yarn.lock` to integration tests only to not be bothered by minor API changes such as babel typing update 
 that [broke nightlies](https://github.com/facebook/metro/actions/runs/11209024584/job/31153626188) this week. 

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D63977061
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

Summary:

Limit the tests we run when installing packages with no `yarn.lock` to integration tests only to not be bothered by minor API changes such as babel typing update 
 that [broke nightlies](https://github.com/facebook/metro/actions/runs/11209024584/job/31153626188) this week. 

Changelog: [Internal]

Reviewed By: huntie

Differential Revision: D63977061
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63977061

@vzaidman vzaidman closed this Oct 17, 2024
@vzaidman
Copy link
Contributor Author

vzaidman commented Oct 17, 2024

not moving forward. manually excluding tests instead: #1373

@vzaidman vzaidman deleted the export-D63977061 branch October 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants